-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#2752] Add math captcha to contactform #1417
Conversation
632eece
to
f1fcd3a
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1417 +/- ##
========================================
Coverage 94.85% 94.85%
========================================
Files 1048 1049 +1
Lines 38783 38837 +54
========================================
+ Hits 36786 36840 +54
Misses 1997 1997 ☔ View full report in Codecov by Sentry. |
107f20b
to
211fcb0
Compare
src/open_inwoner/components/templates/components/Contact/ContactForm.html
Show resolved
Hide resolved
src/open_inwoner/components/templates/components/Contact/ContactForm.html
Show resolved
Hide resolved
c8a62e9
to
b400787
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just nitpicks/FYIs really, also happy to merge this as-is. LGTM.
b400787
to
4aa4351
Compare
4aa4351
to
218ce10
Compare
218ce10
to
cd85a8d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved!
(Also because I need this to merge for proper translations)
</label> | ||
<div class="captcha__check"> | ||
<div> | ||
<span class="captcha__prompt">{{ form_object.captcha.field.question }}</span> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, let's rename it :-)
Taiga: https://taiga.maykinmedia.nl/project/open-inwoner/task/2752